Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zipkin] Replace zipkin exporter from jaeger sdk with otel zipkin exp #4674

Conversation

afzal442
Copy link
Contributor

Which problem is this PR solving?

@afzal442 afzal442 requested a review from a team as a code owner August 15, 2023 08:17
go.mod Outdated Show resolved Hide resolved
@afzal442 afzal442 force-pushed the replace-jaeger-sdk-zipkinExp-with-otel-zexp branch from 76de075 to 386a7d5 Compare August 15, 2023 12:57
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (6b7f073) 97.04% compared to head (68034d6) 97.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4674      +/-   ##
==========================================
- Coverage   97.04%   97.02%   -0.02%     
==========================================
  Files         301      301              
  Lines       17878    17878              
==========================================
- Hits        17350    17347       -3     
- Misses        423      425       +2     
- Partials      105      106       +1     
Flag Coverage Δ
unittests 97.02% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me with these changes

cmd/collector/app/zipkin/http_handler_test.go Outdated Show resolved Hide resolved
cmd/collector/app/zipkin/http_handler_test.go Outdated Show resolved Hide resolved
cmd/collector/app/zipkin/http_handler_test.go Outdated Show resolved Hide resolved
cmd/collector/app/zipkin/http_handler_test.go Outdated Show resolved Hide resolved
cmd/collector/app/zipkin/http_handler_test.go Outdated Show resolved Hide resolved
@afzal442 afzal442 force-pushed the replace-jaeger-sdk-zipkinExp-with-otel-zexp branch from fa15e7e to feea6ff Compare August 17, 2023 07:42
Signed-off-by: Afzal Ansari <afzal442@gmail.com>
Signed-off-by: afzal442 <afzal442@gmail.com>
Signed-off-by: afzal442 <afzal442@gmail.com>
Signed-off-by: afzal442 <afzal442@gmail.com>
Signed-off-by: afzal442 <afzal442@gmail.com>
@afzal442 afzal442 force-pushed the replace-jaeger-sdk-zipkinExp-with-otel-zexp branch from feea6ff to 68034d6 Compare August 17, 2023 07:58
@yurishkuro yurishkuro merged commit 4798446 into jaegertracing:main Aug 17, 2023
31 checks passed
@afzal442 afzal442 deleted the replace-jaeger-sdk-zipkinExp-with-otel-zexp branch August 19, 2023 14:04
@afzal442 afzal442 restored the replace-jaeger-sdk-zipkinExp-with-otel-zexp branch August 19, 2023 14:41
@afzal442 afzal442 deleted the replace-jaeger-sdk-zipkinExp-with-otel-zexp branch August 19, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants