Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates jaeger-idl to current version of OTLP #4682

Closed
wants to merge 1 commit into from
Closed

Updates jaeger-idl to current version of OTLP #4682

wants to merge 1 commit into from

Conversation

tanayvaswani
Copy link

Which problem is this PR solving?

Description of the changes

  • Some required changes in trace.proto, resource.proto, common.proto files under their respective directories in idl/opentelemetry-proto/opentelemetry/proto/ to use the current version of OTLP.
  • Executed make proto command for compiling the proto files into .pb.go

How was this change tested?

  • Through codegen command in Makefile.

Checklist

@tanayvaswani tanayvaswani requested a review from a team as a code owner August 17, 2023 16:29
@tanayvaswani
Copy link
Author

I've done some changes in idl/opentelemetry-proto/opentelemetry/proto/ too, but idk why it isn't getting tracked while pushing the code.

@yurishkuro
Copy link
Member

We need to make the change in idl repo first and then update the sub module here

@tanayvaswani
Copy link
Author

We need to make the change in idl repo first and then update the sub module here

And inside idl repo, changes made in opentelemetry-proto submodule, how can we track that?

@yurishkuro
Copy link
Member

upgrade that too as submodule -- jaegertracing/jaeger-idl#97

@yurishkuro
Copy link
Member

that PR failed in the CI, you may want to investigate, as I won't have time

@tanayvaswani
Copy link
Author

that PR failed in the CI, you may want to investigate, as I won't have time

Yes 2 tests cases were also failed when I checked after changes in my local environment. The reason behind that I haven't completed the 3rd task, I am working on it.

@yurishkuro yurishkuro mentioned this pull request Sep 10, 2023
Merged
yurishkuro added a commit that referenced this pull request Sep 10, 2023
@yurishkuro
Upgrade Query API v3 to official OpenTelemetry format (#4742)
8f680cc 
## Which problem is this PR solving?
- Resolves #4648
- Closes #4682 

## Description of the changes
- pull the latest version of jaeger-idl that uses OTLP v1
- regenerate protobuf types
- remove explicit translation with
`github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/jaeger`
- fix tests. Unfortunately, the actual translation returns error that
cannot be reproduced / tested, thus coverage declined a bit

## How was this change tested?
- CI only

---------

Signed-off-by: Yuri Shkuro <github@ysh.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-elliott joe-elliott Awaiting requested review from joe-elliott joe-elliott is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tanayvaswani @yurishkuro