Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate expvar metrics backend #4740

Merged
merged 2 commits into from Sep 9, 2023

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Sep 9, 2023

Which problem is this PR solving?

Description of the changes

  • add deprecation notice for expvar as metrics backend
  • change HotROD default backend to prometheus

How was this change tested?

  • run binaries locally to observe the messages
$ go run ./cmd/all-in-one help
      --metrics-backend string                                    Defines which metrics backend to use for metrics reporting: prometheus, none, or expvar (deprecated, will be removed after 2024-01-01 or in release v1.53.0, whichever is later)  (default "prometheus")

$ go run ./cmd/all-in-one --metrics-backend=expvar
2023/09/09 19:09:01 using expvar as metrics backend (deprecated, will be removed after 2024-01-01 or in release v1.53.0, whichever is later)

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner September 9, 2023 23:07
Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
internal/metrics/metricsbuilder/builder.go 100.00%

📢 Thoughts on this report? Let us know!.

@yurishkuro yurishkuro merged commit 770b60e into jaegertracing:main Sep 9, 2023
31 checks passed
@yurishkuro yurishkuro deleted the part-of-4722 branch September 9, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant