Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation notice to CLI flags for grpc-storage-plugin sidecar model #4744

Merged
merged 2 commits into from Sep 10, 2023

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • Add deprecation notice to CLI flags
  • Add log statement with deprecation notice

How was this change tested?

$ SPAN_STORAGE_TYPE=grpc-plugin go run ./cmd/all-in-one help

      --grpc-storage-plugin.binary string                         (deprecated, will be removed after 2024-03-01) The location of the plugin binary
      --grpc-storage-plugin.configuration-file string             (deprecated, will be removed after 2024-03-01) A path pointing to the plugin's configuration file, made available to the plugin with the --config arg


$ SPAN_STORAGE_TYPE=grpc-plugin go run ./cmd/all-in-one --grpc-storage-plugin.binary=abcd

2023/09/10 00:39:38 (deprecated, will be removed after 2024-03-01) using sidecar model of grpc-plugin storage, please upgrade to 'reomte' gRPC storage. https://github.com/jaegertracing/jaeger/issues/4647

Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Patch coverage is 70.37% of modified lines.

Files Changed Coverage
cmd/query/app/apiv3/otlp_translator.go 61.53%
cmd/query/app/apiv3/grpc_handler.go 66.66%
plugin/storage/grpc/options.go 100.00%

📢 Thoughts on this report? Let us know!.

@yurishkuro yurishkuro merged commit c8bcf28 into jaegertracing:main Sep 10, 2023
30 of 31 checks passed
@yurishkuro yurishkuro deleted the first-fix-for-4647 branch October 22, 2023 20:42
@yurishkuro yurishkuro changed the title Deprecate grpc-storage-plugin sidecar model Add deprecation notice to CLI flags for grpc-storage-plugin sidecar model Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant