Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace python script with tracegen #4753

Merged

Conversation

albertteoh
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • Replaces the python example with tracegen in order to reduce maintenance needed on the script.

How was this change tested?

  • Ran locally E2E to confirm traces and metrics are appearing in Jaeger UI.

Checklist

Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
@albertteoh albertteoh requested a review from a team as a code owner September 12, 2023 13:03
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

docker run --env OTEL_EXPORTER_OTLP_TRACES_ENDPOINT="http://otel_collector:4317" \
--network monitor_backend \
--rm \
jaegertracing/jaeger-tracegen:1.49 \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if there's a preference to use the latest tag.

yurishkuro
yurishkuro previously approved these changes Sep 12, 2023
@yurishkuro
Copy link
Member

you can also remove the respective section in .github/dependabot.yml

Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
@@ -22,8 +22,6 @@ services:
volumes:
- ${OTEL_CONFIG_SRC:-./otel-collector-config-connector.yml}:/etc/otelcol/otel-collector-config.yml
command: --config /etc/otelcol/otel-collector-config.yml
ports:
- "4317:4317"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I've also removed this as we're executing tracegen in the same monitor_backend network. Tested this locally to make sure:

# Fail to access the port from host machine.
$ telnet localhost 4317
Trying 127.0.0.1...
telnet: Unable to connect to remote host: Connection refused

# Successfully write to port from docker command.
$ docker run --env OTEL_EXPORTER_OTLP_TRACES_ENDPOINT="http://otel_collector:4317" \
  --network monitor_backend \
  --rm \
  jaegertracing/jaeger-tracegen:1.49 \
    -trace-exporter otlp-grpc \
    -traces 1
...
2023-09-12T20:40:01.903Z	LEVEL(-8)	global/internal_logging.go:62	exporting spans	{"count": 2, "total_dropped": 0}

@albertteoh
Copy link
Contributor Author

you can also remove the respective section in .github/dependabot.yml

Nice, thanks. Removed in: b850f02

@yurishkuro yurishkuro merged commit e2aa161 into jaegertracing:main Sep 12, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[spm] Change README to use tracegen
2 participants