Run all integration tests against Cassandra #4773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <github@ysh.us>
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
4 tasks
yurishkuro
pushed a commit
that referenced
this pull request
Sep 29, 2023
## Which problem is this PR solving? Resolves #4782 ## Description of the changes - Recently a [PR](#4773) was raised to run all integration tests against Cassandra while checking it's [CI for cassandra](https://github.com/jaegertracing/jaeger/actions/runs/6287799686/job/17072619668) I found that the some test where failing but CI passed. - Fixed the script so that if the test fail we get exit code as non-zero. - Fixed `TestCassandraStorage/GetLargeSpans` test which was failing due to older traces not getting cleanup from db. ## How was this change tested? - run the cassandra script to test it. ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: slayer321 <sachin.maurya7666@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?