Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use setup-node.js for Publish Release #4816

Merged
merged 1 commit into from Oct 7, 2023

Conversation

albertteoh
Copy link
Contributor

Description of the changes

  • Fix this CI build error, using ci-docker-build.yml and ci-build-binaries.yml and ci-all-in-one-build.yml as examples:
ERROR: installed Node version v16.20.2 doesn't match expected version v18

How was this change tested?

  • Test in CI pipeline; maybe there's a better way to test?

Checklist

Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
@albertteoh albertteoh requested a review from a team as a code owner October 7, 2023 10:33
@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

All modified lines are covered by tests ✅

see 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@yurishkuro yurishkuro merged commit 2bb7ee4 into jaegertracing:main Oct 7, 2023
31 checks passed
@albertteoh albertteoh deleted the use-setup-node branch October 7, 2023 19:45
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants