Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use commit hash as image label when building & integration-testing #4824

Merged
merged 3 commits into from
Oct 8, 2023
Merged

Use commit hash as image label when building & integration-testing #4824

merged 3 commits into from
Oct 8, 2023

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • Just to validate that the correct image is being tested, use the exact commit sha instead of latest as image tag when building & running for local testing

How was this change tested?

  • CI

@yurishkuro yurishkuro requested a review from a team as a code owner October 8, 2023 03:03
@codecov
Copy link

codecov bot commented Oct 8, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

yurishkuro and others added 2 commits October 7, 2023 23:18
@yurishkuro
fix
2a6ed1e 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
Merge branch 'main' into all-in-one-integration-test
1788d64
@yurishkuro yurishkuro merged commit 2c19a6a into jaegertracing:main Oct 8, 2023
31 checks passed
@yurishkuro yurishkuro deleted the all-in-one-integration-test branch October 8, 2023 04:50
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkowall jkowall Awaiting requested review from jkowall jkowall is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Wrong all-in-one being tested in CI
1 participant
@yurishkuro