Add CI validation of shell scripts using shellcheck

[akagami-harsh]

Which problem is this PR solving?

Resolves #4822

Description of the changes

• fixed all 83 warnings produced by shellcheck
• added a workflow for shellcheck

How was this change tested?

• CI

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully
  • for jaeger: make lint test
  • for jaeger-ui: yarn lint and yarn test

[yurishkuro]

I reviewed the first few files, the same mistake is repeated over and over. When a variable is meant to represent multiple arguments like x="a b c", using it in quotes "${x}" means all those values will be given to the command as a single argument, the same as passing a\ b\ c. This breaks the semantic of most of the scripts.

[akagami-harsh]

I reviewed the first few files, the same mistake is repeated over and over. When a variable is meant to represent multiple arguments like x="a b c", using it in quotes "${x}" means all those values will be given to the command as a single argument, the same as passing a\ b\ c. This breaks the semantic of most of the scripts.

@yurishkuro Thank you for taking the time to review my code and providing valuable feedback. I was so fixated on resolving those shellcheck warnings, that I forgot it was breaking the sole purpose of the code. I revisited all of it again and made some changes , can you review it again

[akagami-harsh]

can you please add the Hacktoberfest label

[akagami-harsh]

@yurishkuro , i have made some changes, can you please review it.

[codecov]

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

[yurishkuro]

looking good! 🎉

[yurishkuro]

Thanks!