Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add more linters #4881

Merged
merged 3 commits into from Oct 22, 2023
Merged

test: Add more linters #4881

merged 3 commits into from Oct 22, 2023

Conversation

yurishkuro
Copy link
Member

Description of the changes

  • Enable more linters
  • Fix issues currently reported

How was this change tested?

  • make lint

@yurishkuro
ci: Add more linters
7210a52 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
ci: Add more linters
5d9a8ac 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
more linters
26c848c 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner October 22, 2023 02:47
@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Files Coverage Δ
cmd/internal/status/command.go 100.00% <100.00%> (ø)
internal/metricstest/local.go 100.00% <100.00%> (ø)
pkg/es/client/client.go 87.50% <100.00%> (+0.46%) ⬆️
plugin/metrics/disabled/reader.go 100.00% <100.00%> (ø)
...in/sampling/strategystore/static/strategy_store.go 96.03% <66.66%> (-1.23%) ⬇️

... and 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Oct 22, 2023
@yurishkuro yurishkuro merged commit 6687d6e into jaegertracing:main Oct 22, 2023
32 of 34 checks passed
@yurishkuro yurishkuro deleted the linters branch October 22, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkowall jkowall Awaiting requested review from jkowall jkowall is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@yurishkuro