Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Pass variable instead of calling make build-xxx-debug #4883

Merged
merged 2 commits into from Oct 23, 2023

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

  • Follow up to $4882
  • Crossdock and all-in-one workflows failed on main branch

Description of the changes

  • build-all-in-one-debug target was removed, call make build-all-in-one DEBUG_BINARY=1
  • fix invalid variable quoting in scripts/build-crossdock.sh

How was this change tested?

  • Will check CI once this is merged

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner October 23, 2023 00:35
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@yurishkuro yurishkuro merged commit d7450ef into jaegertracing:main Oct 23, 2023
34 checks passed
@yurishkuro yurishkuro deleted the fix-4882 branch October 23, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant