Add reload interval to OTel server certificates #4898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Ryans <james.ryans2012@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 2 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
yurishkuro
reviewed
Oct 26, 2023
pkg/config/tlscfg/flags.go
Outdated
| @@ -66,6 +67,7 @@ func (c ServerFlagsConfig) AddFlags(flags *flag.FlagSet) { | |||
| flags.String(c.Prefix+tlsCipherSuites, "", "Comma-separated list of cipher suites for the server, values are from tls package constants (https://golang.org/pkg/crypto/tls/#pkg-constants).") | |||
| flags.String(c.Prefix+tlsMinVersion, "", "Minimum TLS version supported (Possible values: 1.0, 1.1, 1.2, 1.3)") | |||
| flags.String(c.Prefix+tlsMaxVersion, "", "Maximum TLS version supported (Possible values: 1.0, 1.1, 1.2, 1.3)") | |||
| flags.Duration(c.Prefix+tlsReloadInterval, 0, "The duration after which the certificate will be reloaded (0s means will not be reloaded)") | |||
There was a problem hiding this comment.
We need to add a capability, e.g. ServerFlagsConfig.EnableCertReloadInterval, to enable/disable this option. Otherwise it will show up in all uses of the tlscfg, including the many places which do NOT implement the reload functionality today (but may implement file watching).
…d otlp.grpc.tls flags Signed-off-by: James Ryans <james.ryans2012@gmail.com>
Signed-off-by: James Ryans <james.ryans2012@gmail.com>
james-ryans
changed the title
yurishkuro
reviewed
Oct 27, 2023
Signed-off-by: James Ryans <james.ryans2012@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
otlp.http.tls.reload-intervalandotlp.grpc.tls.reload-intervalflags (0s means disabled)How was this change tested?
*.tls.reload-intervalflag unit tests toflags.goandotel_receiver.goChecklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test