Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all-in-one metric names match metrics from standalone components #5008

Merged
merged 1 commit into from Dec 17, 2023

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Dec 15, 2023

Which problem is this PR solving?

Description of the changes

  • provide proper namespaces for different sub-components (agent, collector, query) running in all-in-one, to match the metrics names produces by these components when running standalone

How was this change tested?

  • go run ./cmd/all-in-one
  • curl http://localhost:14269/metrics | grep -v '#'
  • compare before/after textcompare-diff.pdf

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner December 15, 2023 21:28
@yurishkuro yurishkuro added the changelog:breaking-change Change that is breaking public APIs or established behavior label Dec 15, 2023
@yurishkuro yurishkuro changed the title Fix metric names in all-in-one Make all-in-one metric names match metrics from standalone components Dec 15, 2023
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b5f73ae) 95.64% compared to head (5c41fce) 95.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5008      +/-   ##
==========================================
- Coverage   95.64%   95.62%   -0.02%     
==========================================
  Files         319      319              
  Lines       18786    18786              
==========================================
- Hits        17968    17965       -3     
- Misses        657      659       +2     
- Partials      161      162       +1     
Flag Coverage Δ
cassandra-3.x 25.63% <ø> (ø)
cassandra-4.x 25.63% <ø> (ø)
elasticsearch-5.x 19.89% <ø> (-0.02%) ⬇️
elasticsearch-6.x 19.90% <ø> (ø)
elasticsearch-7.x 20.04% <ø> (ø)
elasticsearch-8.x 20.13% <ø> (ø)
grpc-badger 19.52% <ø> (ø)
kafka 14.12% <ø> (ø)
opensearch-1.x 20.04% <ø> (+0.01%) ⬆️
opensearch-2.x 20.02% <ø> (-0.02%) ⬇️
unittests 93.37% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@albertteoh albertteoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder if it's easy to write a unit test to validate the namespaces attached to a metrics factory to prevent future regressions?

@yurishkuro
Copy link
Member Author

main isn't easily testable without serious refactoring. This will be better in jaeger-v2

@yurishkuro yurishkuro merged commit 747ee8d into jaegertracing:main Dec 17, 2023
37 of 38 checks passed
@yurishkuro yurishkuro deleted the fix-5007 branch December 17, 2023 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:breaking-change Change that is breaking public APIs or established behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Jaeger prometheus metrics are missing "collector" prefix?
2 participants