Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add goleak check to packages with empty tests #5017

Merged
merged 1 commit into from Dec 19, 2023

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • Add goleak checks to all packages with empty_test.go as well as ./storage/... (which mostly contains APIs)

How was this change tested?

  • CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner December 19, 2023 02:14
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Dec 19, 2023
@yurishkuro
Copy link
Member Author

cc @akagami-harsh

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4113075) 52.64% compared to head (2402b4b) 95.62%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5017       +/-   ##
===========================================
+ Coverage   52.64%   95.62%   +42.98%     
===========================================
  Files         145      319      +174     
  Lines        8593    18786    +10193     
===========================================
+ Hits         4524    17965    +13441     
+ Misses       3721      659     -3062     
+ Partials      348      162      -186     
Flag Coverage Δ
cassandra-3.x 25.63% <ø> (ø)
cassandra-4.x 25.63% <ø> (ø)
elasticsearch-5.x 19.89% <ø> (ø)
elasticsearch-6.x 19.89% <ø> (-0.02%) ⬇️
elasticsearch-7.x 20.04% <ø> (ø)
elasticsearch-8.x 20.13% <ø> (ø)
grpc-badger 19.52% <ø> (ø)
kafka 14.12% <ø> (ø)
opensearch-1.x 20.02% <ø> (ø)
opensearch-2.x 20.02% <ø> (-0.02%) ⬇️
unittests 93.37% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jkowall jkowall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks.

@yurishkuro yurishkuro merged commit 09080e6 into jaegertracing:main Dec 19, 2023
37 of 38 checks passed
@yurishkuro yurishkuro deleted the goleak-empty-storage branch December 19, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants