Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Protobuf types generation #5037

Merged
merged 12 commits into from Dec 25, 2023

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Dec 25, 2023

Which problem is this PR solving?

  • It was no longer possible to run make proto on Macs with Apple silicon since the Docker image with protobuf was only built for amd64.
  • We are generating unoptimized protobuf types for OTLP without Gogo, which will be a problem for jaeger-v2

Description of the changes

How was this change tested?

  • make proto regenerates all the files without any additional changes

Next steps

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Dec 25, 2023
Signed-off-by: Yuri Shkuro <github@ysh.us>
Copy link

codecov bot commented Dec 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (16985d4) 52.59% compared to head (577ffcd) 95.61%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5037       +/-   ##
===========================================
+ Coverage   52.59%   95.61%   +43.01%     
===========================================
  Files         145      319      +174     
  Lines        8599    18794    +10195     
===========================================
+ Hits         4523    17970    +13447     
+ Misses       3728      661     -3067     
+ Partials      348      163      -185     
Flag Coverage Δ
cassandra-3.x 25.61% <ø> (ø)
cassandra-4.x 25.61% <ø> (ø)
elasticsearch-5.x 19.88% <ø> (ø)
elasticsearch-6.x 19.87% <ø> (-0.02%) ⬇️
elasticsearch-7.x 20.02% <ø> (+0.01%) ⬆️
elasticsearch-8.x 20.11% <ø> (ø)
grpc-badger 19.50% <ø> (ø)
kafka 14.10% <ø> (ø)
opensearch-1.x 20.02% <ø> (ø)
opensearch-2.x 20.00% <ø> (ø)
unittests 93.35% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yurishkuro and others added 2 commits December 25, 2023 17:14
@yurishkuro yurishkuro marked this pull request as ready for review December 25, 2023 22:15
@yurishkuro yurishkuro requested a review from a team as a code owner December 25, 2023 22:15
Makefile.Protobuf.mk Show resolved Hide resolved
@yurishkuro yurishkuro merged commit a798e25 into jaegertracing:main Dec 25, 2023
38 checks passed
@yurishkuro yurishkuro deleted the Makefile.Protobuf branch December 25, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants