Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding artifacthub badge #5383

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

jkowall
Copy link
Contributor

@jkowall jkowall commented Apr 23, 2024

Which problem is this PR solving?

This adds the artifact hub badge for Jaeger, which will be official once the last PR is pushed from the helm chart repo.

#5363

Description of the changes

Add new image on README.md

How was this change tested?

Tested on Github branch

Checklist

Signed-off-by: Jonah Kowall <jkowall@kowall.net>
@jkowall jkowall requested a review from a team as a code owner April 23, 2024 18:46
@jkowall jkowall requested a review from yurishkuro April 23, 2024 18:46
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.20%. Comparing base (a72dfc3) to head (f27cf86).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5383   +/-   ##
=======================================
  Coverage   95.20%   95.20%           
=======================================
  Files         343      343           
  Lines       16813    16813           
=======================================
  Hits        16006    16006           
  Misses        608      608           
  Partials      199      199           
Flag Coverage Δ
badger 10.47% <ø> (ø)
cassandra-3.x 18.38% <ø> (ø)
cassandra-4.x 18.38% <ø> (ø)
elasticsearch-5.x 20.90% <ø> (ø)
elasticsearch-6.x 20.89% <ø> (-0.05%) ⬇️
elasticsearch-7.x 20.95% <ø> (-0.04%) ⬇️
elasticsearch-8.x 21.17% <ø> (+0.04%) ⬆️
grpc 14.55% <ø> (ø)
kafka 10.17% <ø> (ø)
opensearch-1.x 20.97% <ø> (ø)
opensearch-2.x 20.98% <ø> (+0.01%) ⬆️
unittests 91.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:skip Trivial change that does not require an entry in CHANGELOG label Apr 23, 2024
@yurishkuro yurishkuro merged commit 9a8b049 into jaegertracing:main Apr 23, 2024
37 of 38 checks passed
varshith257 pushed a commit to varshith257/jaeger that referenced this pull request May 3, 2024
## Which problem is this PR solving?
This adds the artifact hub badge for Jaeger, which will be official once
the last PR is pushed from the helm chart repo.

jaegertracing#5363

## Description of the changes
Add new image on README.md

## How was this change tested?
Tested on Github branch

## Checklist
- [X] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [X] I have signed all commits
- [NA] I have added unit tests for the new functionality
- [NA] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

Signed-off-by: Jonah Kowall <jkowall@kowall.net>
Signed-off-by: Vamshi Maskuri <gwcchintu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Trivial change that does not require an entry in CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants