Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query/tests] Use grpc.NewClient #5391

Merged
merged 24 commits into from May 12, 2024
Merged

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Apr 26, 2024

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.50%. Comparing base (98abc11) to head (8f69cee).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5391   +/-   ##
=======================================
  Coverage   95.50%   95.50%           
=======================================
  Files         331      331           
  Lines       16107    16109    +2     
=======================================
+ Hits        15383    15385    +2     
  Misses        551      551           
  Partials      173      173           
Flag Coverage Δ
badger_v1 8.08% <ø> (ø)
badger_v2 1.94% <ø> (ø)
cassandra-3.x-v1 16.49% <ø> (ø)
cassandra-3.x-v2 1.86% <ø> (ø)
cassandra-4.x-v1 16.49% <ø> (ø)
cassandra-4.x-v2 1.86% <ø> (ø)
elasticsearch-7.x 1.78% <ø> (?)
elasticsearch-8.x 1.77% <ø> (?)
grpc_v1 9.12% <ø> (ø)
grpc_v2 7.49% <ø> (+0.01%) ⬆️
kafka 9.82% <ø> (ø)
opensearch-1.x 1.78% <ø> (?)
opensearch-2.x 1.78% <ø> (?)
unittests 94.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yurishkuro and others added 3 commits April 26, 2024 21:01
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro added the changelog:dependencies Update to dependencies label Apr 27, 2024
@yurishkuro yurishkuro changed the title Use grpc.NewClient [query] Use grpc.NewClient Apr 28, 2024
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro changed the title [query] Use grpc.NewClient [query/tests] Use grpc.NewClient Apr 28, 2024
@yurishkuro yurishkuro added changelog:test Change that's adding missing tests or correcting existing tests and removed changelog:dependencies Update to dependencies labels Apr 28, 2024
yurishkuro and others added 13 commits April 28, 2024 19:01
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro marked this pull request as ready for review May 12, 2024 02:22
@yurishkuro yurishkuro requested a review from a team as a code owner May 12, 2024 02:22
return &fakeQueryService{
qs: qs,
spanReader: spanReader,
dependencyReader: dependencyReader,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the dependencyReader used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably not

@yurishkuro yurishkuro merged commit a2a9188 into jaegertracing:main May 12, 2024
39 checks passed
@yurishkuro yurishkuro deleted the newclient branch May 12, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:test Change that's adding missing tests or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants