Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[agent] Use grpc.NewClient #5392

Merged
merged 1 commit into from Apr 27, 2024
Merged

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Apr 27, 2024

Which problem is this PR solving?

Description of the changes

  • Use grpc.NewClient
  • Remove irrelevant tests for connection status

How was this change tested?

  • CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro added changelog:test Change that's adding missing tests or correcting existing tests changelog:bugfix-or-minor-feature and removed changelog:test Change that's adding missing tests or correcting existing tests labels Apr 27, 2024
Copy link

codecov bot commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.20%. Comparing base (e5dd759) to head (446d206).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5392       +/-   ##
===========================================
+ Coverage   55.51%   95.20%   +39.69%     
===========================================
  Files         171      346      +175     
  Lines        9048    16908     +7860     
===========================================
+ Hits         5023    16098    +11075     
+ Misses       3554      610     -2944     
+ Partials      471      200      -271     
Flag Coverage Δ
badger_v1 10.47% <ø> (ø)
badger_v2 6.42% <ø> (?)
cassandra-3.x 18.37% <ø> (?)
cassandra-4.x 18.37% <ø> (ø)
elasticsearch-5.x 20.91% <ø> (?)
elasticsearch-6.x 20.91% <ø> (?)
elasticsearch-7.x 20.96% <ø> (?)
elasticsearch-8.x 21.14% <ø> (?)
grpc_v1 12.62% <ø> (ø)
grpc_v2 11.54% <ø> (ø)
kafka 10.18% <ø> (ø)
opensearch-1.x 21.00% <ø> (+0.01%) ⬆️
opensearch-2.x 20.98% <ø> (-0.06%) ⬇️
unittests 91.54% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro marked this pull request as ready for review April 27, 2024 01:55
@yurishkuro yurishkuro requested a review from a team as a code owner April 27, 2024 01:55
Copy link
Contributor

@jkowall jkowall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yurishkuro yurishkuro merged commit 28150fc into jaegertracing:main Apr 27, 2024
41 of 42 checks passed
varshith257 pushed a commit to varshith257/jaeger that referenced this pull request May 3, 2024
Signed-off-by: Vamshi Maskuri <gwcchintu@gmail.com>
@yurishkuro yurishkuro deleted the newclient2 branch May 3, 2024 13:32
Pushkarm029 pushed a commit to Pushkarm029/jaeger that referenced this pull request May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants