Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Add logging to read/write spans in e2e tests #5456

Merged
merged 1 commit into from
May 16, 2024

Conversation

james-ryans
Copy link
Contributor

Which problem is this PR solving?

  • Helps to debug unstable e2e tests in jaeger-v2 e22 tests are unstable #5418
  • Current logs are still hard to follow even it already dump storage's docker and OTEL col binary logs because we can't see which part of the test related to which storage docker/ OTEL col binary logs.

Description of the changes

  • Add more logging to e2e tests that capture the timestamp of each read/write run.

How was this change tested?

  • Run STORAGE=grpc SPAN_STORAGE_TYPE=memory make jaeger-v2-storage-integration-test

Checklist

Signed-off-by: James Ryans <james.ryans2012@gmail.com>
@james-ryans james-ryans requested a review from a team as a code owner May 16, 2024 15:34
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label May 16, 2024
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.48%. Comparing base (7df05d9) to head (68ee0a6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5456      +/-   ##
==========================================
+ Coverage   95.46%   95.48%   +0.01%     
==========================================
  Files         331      331              
  Lines       16112    16112              
==========================================
+ Hits        15382    15384       +2     
+ Misses        556      555       -1     
+ Partials      174      173       -1     
Flag Coverage Δ
badger_v1 8.08% <ø> (ø)
badger_v2 1.94% <ø> (?)
cassandra-3.x-v1 16.48% <ø> (ø)
cassandra-3.x-v2 1.86% <ø> (ø)
cassandra-4.x-v1 16.48% <ø> (ø)
cassandra-4.x-v2 1.86% <ø> (ø)
elasticsearch-7.x 1.78% <ø> (+0.01%) ⬆️
elasticsearch-8.x 1.77% <ø> (-0.02%) ⬇️
grpc_v1 9.11% <ø> (ø)
grpc_v2 7.49% <ø> (ø)
kafka 9.81% <ø> (ø)
opensearch-1.x 1.78% <ø> (+0.01%) ⬆️
opensearch-2.x 1.78% <ø> (+0.01%) ⬆️
unittests 93.99% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro enabled auto-merge (squash) May 16, 2024 16:15
@yurishkuro yurishkuro merged commit 14cbcea into jaegertracing:main May 16, 2024
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants