Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[adaptive] Separate Provider and Aggregator settings #5639

Closed

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Copy link

codecov bot commented Jun 16, 2024

Codecov Report

Attention: Patch coverage is 97.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.22%. Comparing base (082d2e0) to head (42003db).

Files Patch % Lines
cmd/collector/app/collector.go 95.00% 0 Missing and 1 partial ⚠️
...in/sampling/strategyprovider/adaptive/processor.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5639      +/-   ##
==========================================
+ Coverage   96.19%   96.22%   +0.03%     
==========================================
  Files         327      326       -1     
  Lines       16014    16010       -4     
==========================================
+ Hits        15404    15406       +2     
+ Misses        433      427       -6     
  Partials      177      177              
Flag Coverage Δ
badger_v1 8.05% <6.25%> (-0.01%) ⬇️
badger_v2 1.93% <0.00%> (-0.01%) ⬇️
cassandra-3.x-v1 16.44% <6.25%> (-0.01%) ⬇️
cassandra-3.x-v2 1.85% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v1 16.44% <6.25%> (-0.01%) ⬇️
cassandra-4.x-v2 1.85% <0.00%> (-0.01%) ⬇️
elasticsearch-7.x-v1 18.89% <6.25%> (+<0.01%) ⬆️
elasticsearch-8.x-v1 19.08% <6.25%> (+<0.01%) ⬆️
elasticsearch-8.x-v2 19.07% <6.25%> (-0.02%) ⬇️
grpc_v1 9.51% <56.25%> (+0.03%) ⬆️
grpc_v2 7.56% <50.00%> (+0.02%) ⬆️
kafka 9.77% <25.00%> (-0.01%) ⬇️
opensearch-1.x-v1 18.92% <6.25%> (-0.01%) ⬇️
opensearch-2.x-v1 18.93% <6.25%> (+<0.01%) ⬆️
opensearch-2.x-v2 18.92% <6.25%> (-0.02%) ⬇️
unittests 94.10% <96.66%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant