Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary .nocover files #5642

Merged
merged 5 commits into from
Jun 18, 2024

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • Remove unnecessary .nocover files.

How was this change tested?

  • Check if this affects coverage in CI.

Signed-off-by: Yuri Shkuro <github@ysh.us>
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (60c2efb) to head (5136427).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5642   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files         327      327           
  Lines       16016    16018    +2     
=======================================
+ Hits        15431    15433    +2     
  Misses        407      407           
  Partials      178      178           
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 1.93% <ø> (ø)
cassandra-3.x-v1 16.45% <ø> (ø)
cassandra-3.x-v2 1.85% <ø> (ø)
cassandra-4.x-v1 16.45% <ø> (ø)
cassandra-4.x-v2 1.85% <ø> (ø)
elasticsearch-7.x-v1 18.89% <ø> (ø)
elasticsearch-8.x-v1 19.09% <ø> (+0.01%) ⬆️
elasticsearch-8.x-v2 19.09% <ø> (ø)
grpc_v1 9.48% <ø> (+0.01%) ⬆️
grpc_v2 7.53% <ø> (ø)
kafka 9.77% <ø> (ø)
opensearch-1.x-v1 18.94% <ø> (ø)
opensearch-2.x-v1 18.94% <ø> (ø)
opensearch-2.x-v2 18.94% <ø> (ø)
unittests 94.22% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Jun 17, 2024
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro marked this pull request as ready for review June 17, 2024 21:13
@yurishkuro yurishkuro requested a review from a team as a code owner June 17, 2024 21:13
Copy link
Contributor

@jkowall jkowall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yurishkuro yurishkuro merged commit b711518 into jaegertracing:main Jun 18, 2024
41 checks passed
@yurishkuro yurishkuro deleted the cleanup-nocover branch June 18, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants