Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SPM make build #5662

Closed
wants to merge 1 commit into from
Closed

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

  • SPM Makefile was calling a target that was removed in previous refactoring

Description of the changes

  • Build the image directly instead of calling much more expensive target
  • Change crossdock target to not build debug image with devle, which is expensive

How was this change tested?

  • make build && make dev

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner June 19, 2024 17:55
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.11%. Comparing base (1c1f22b) to head (98a63af).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5662       +/-   ##
===========================================
- Coverage   96.37%   54.11%   -42.26%     
===========================================
  Files         327      163      -164     
  Lines       16028     8413     -7615     
===========================================
- Hits        15447     4553    -10894     
- Misses        404     3415     +3011     
- Partials      177      445      +268     
Flag Coverage Δ
badger_v1 8.04% <ø> (ø)
badger_v2 1.92% <ø> (-0.01%) ⬇️
cassandra-3.x-v1 16.60% <ø> (ø)
cassandra-3.x-v2 1.84% <ø> (-0.01%) ⬇️
cassandra-4.x-v1 16.60% <ø> (ø)
cassandra-4.x-v2 ?
elasticsearch-7.x-v1 ?
elasticsearch-8.x-v1 19.05% <ø> (-0.02%) ⬇️
elasticsearch-8.x-v2 19.06% <ø> (ø)
grpc_v1 9.46% <ø> (-0.02%) ⬇️
grpc_v2 ?
kafka 9.76% <ø> (ø)
opensearch-1.x-v1 18.91% <ø> (-0.02%) ⬇️
opensearch-2.x-v1 18.92% <ø> (ø)
opensearch-2.x-v2 18.92% <ø> (+0.01%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro closed this Jun 19, 2024
@yurishkuro yurishkuro deleted the fix-spm-build branch June 19, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant