New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report card fixes #583

Merged
merged 8 commits into from Dec 5, 2017

Conversation

Projects
None yet
3 participants
@isaachier
Contributor

isaachier commented Dec 5, 2017

Fixes #582.

isaachier added some commits Dec 5, 2017

gofmt fix
Signed-off-by: Isaac Hier <isaachier@gmail.com>
gocyclo fixes
Signed-off-by: Isaac Hier <isaachier@gmail.com>
Fixes for golint and ineffassign
Signed-off-by: Isaac Hier <isaachier@gmail.com>

isaachier added some commits Dec 5, 2017

Add documentation for new FlattenTags method
Signed-off-by: Isaac Hier <isaachier@gmail.com>
Fix test case assertion
Signed-off-by: Isaac Hier <isaachier@gmail.com>
Show outdated Hide outdated examples/hotrod/services/driver/redis.go Outdated
Show outdated Hide outdated storage/samplingstore/mocks/Store.go Outdated
Show outdated Hide outdated pkg/distributedlock/mocks/Lock.go Outdated
Show outdated Hide outdated model/span.go Outdated
Show outdated Hide outdated model/keyvalue.go Outdated
Show outdated Hide outdated model/keyvalue.go Outdated
Fix tests
Signed-off-by: Isaac Hier <isaachier@gmail.com>
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 5, 2017

Coverage Status

Coverage decreased (-0.2%) to 99.763% when pulling ec5eeff on isaachier:report-card-fixes into e86551d on jaegertracing:master.

coveralls commented Dec 5, 2017

Coverage Status

Coverage decreased (-0.2%) to 99.763% when pulling ec5eeff on isaachier:report-card-fixes into e86551d on jaegertracing:master.

Undo changes in generated code and keep helpers private
Signed-off-by: Isaac Hier <isaachier@gmail.com>
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 5, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling d9bd9f4 on isaachier:report-card-fixes into e86551d on jaegertracing:master.

coveralls commented Dec 5, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling d9bd9f4 on isaachier:report-card-fixes into e86551d on jaegertracing:master.

Show outdated Hide outdated storage/spanstore/memory/memory.go Outdated
@isaachier

This comment has been minimized.

Show comment
Hide comment
@isaachier

isaachier Dec 5, 2017

Contributor

Anyone want to merge this?

Contributor

isaachier commented Dec 5, 2017

Anyone want to merge this?

Fix typo
Signed-off-by: Isaac Hier <ihier@uber.com>
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 5, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling b9febd2 on isaachier:report-card-fixes into e86551d on jaegertracing:master.

coveralls commented Dec 5, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling b9febd2 on isaachier:report-card-fixes into e86551d on jaegertracing:master.

@yurishkuro yurishkuro merged commit 1e10ffc into jaegertracing:master Dec 5, 2017

3 checks passed

DCO All commits have a DCO sign-off from the author
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@isaachier isaachier deleted the isaachier:report-card-fixes branch Aug 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment