Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky test #655

Merged
merged 1 commit into from
Jan 17, 2018
Merged

Fix flaky test #655

merged 1 commit into from
Jan 17, 2018

Conversation

yurishkuro
Copy link
Member 

=== RUN   TestNewFactory
--- FAIL: TestNewFactory (0.00s)
	Error Trace:	factory_test.go:66
	Error:      	Not equal: 
	            	expected: "Unknown storage type x."
	            	actual: "Unknown storage type y."

Signed-off-by: Yuri Shkuro ys@uber.com

Fix flaky test
26c04ca 
Signed-off-by: Yuri Shkuro <ys@uber.com>
@ghost ghost assigned yurishkuro Jan 17, 2018
@ghost ghost added the review label Jan 17, 2018
@yurishkuro yurishkuro mentioned this pull request Jan 17, 2018
Merged
@yurishkuro yurishkuro merged commit 8c55478 into master Jan 17, 2018
@ghost ghost removed the review label Jan 17, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 26c04ca on fix-test into 1f05b2d on master.

@yurishkuro yurishkuro deleted the fix-test branch May 6, 2018 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@black-adder black-adder black-adder approved these changes

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@vprithvi vprithvi Awaiting requested review from vprithvi

Assignees

@yurishkuro yurishkuro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yurishkuro @coveralls @black-adder