Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --es.disable-basic-auth option #686

Closed

Conversation

bpot
Copy link

@bpot bpot commented Feb 6, 2018

This is useful when using Amazon's Elasticsearch service with a VPC
endpoint and ip-based access control.

I also considered automatically skipping the SetBasicAuth option if username and password were empty but it seems nicer to make it explicit.

This is useful when using Amazon's Elasticsearch service with a VPC
endpoint and ip-based access control.

Signed-off-by: Bob Potter <bobby.potter@gmail.com>
@coveralls
Copy link

coveralls commented Feb 6, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 7b7d4c4 on ReturnPath:bp/no_basic_auth into ee916be on jaegertracing:master.

@yurishkuro
Copy link
Member

I don't think this is needed. If the username or password are blank, the basic auth will already be disabled. E.g. this is what the olivere's driver does

func SetBasicAuth(username, password string) ClientOptionFunc {
	return func(c *Client) error {
		c.basicAuthUsername = username
		c.basicAuthPassword = password
		c.basicAuth = c.basicAuthUsername != "" || c.basicAuthPassword != ""
		return nil
	}
}

@bpot
Copy link
Author

bpot commented Feb 6, 2018

It looks like you're right. I was using docker image 1.0.0 and everything is working with 1.1.0. The problem was probably the lack of ssl certs in 1.0.0 and not basic auth.

@bpot bpot closed this Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants