Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune create on custom index to not be created if it already exists. #782

Merged
merged 1 commit into from
Apr 23, 2018
Merged

Tune create on custom index to not be created if it already exists. #782

merged 1 commit into from
Apr 23, 2018

Conversation

gregswift
Copy link
Contributor

@gregswift gregswift commented Apr 23, 2018

This prevents schema upgrades or re-executions from erroring.

Closes jaegertracing/jaeger-openshift#79

@coveralls
Copy link

coveralls commented Apr 23, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 294c0fb on gregswift:not-exists into cfb68d6 on jaegertracing:master.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yurishkuro
Copy link
Member

Please sign the commit, eg

git commit -s --amend

Then force push.

@gregswift
Copy link
Contributor Author

@jpkrohling signed

…his prevents schema upgrades or re-executions from erroring

Signed-off-by: Greg Swift <gregswift@gmail.com>
@gregswift
Copy link
Contributor Author

update: i used -S not -s.. fixed.

@yurishkuro yurishkuro merged commit ddaf483 into jaegertracing:master Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants