Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune create on custom index to not be created if it already exists. #782

Merged
merged 1 commit into from Apr 23, 2018

Conversation

Projects
None yet
4 participants
@gregswift
Copy link
Contributor

gregswift commented Apr 23, 2018

This prevents schema upgrades or re-executions from erroring.

Closes jaegertracing/jaeger-openshift#79

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 23, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 294c0fb on gregswift:not-exists into cfb68d6 on jaegertracing:master.

@yurishkuro
Copy link
Member

yurishkuro left a comment

Thanks!

@yurishkuro

This comment has been minimized.

Copy link
Member

yurishkuro commented Apr 23, 2018

Please sign the commit, eg

git commit -s --amend

Then force push.

@gregswift gregswift force-pushed the gregswift:not-exists branch from fa0faf1 to 7c0a952 Apr 23, 2018

@gregswift

This comment has been minimized.

Copy link
Contributor Author

gregswift commented Apr 23, 2018

@jpkrohling signed

@gregswift gregswift force-pushed the gregswift:not-exists branch from 7c0a952 to f076ace Apr 23, 2018

Tune create on custom index to not be created if it already exists. T…
…his prevents schema upgrades or re-executions from erroring

Signed-off-by: Greg Swift <gregswift@gmail.com>

@gregswift gregswift force-pushed the gregswift:not-exists branch from f076ace to 294c0fb Apr 23, 2018

@gregswift

This comment has been minimized.

Copy link
Contributor Author

gregswift commented Apr 23, 2018

update: i used -S not -s.. fixed.

@yurishkuro yurishkuro merged commit ddaf483 into jaegertracing:master Apr 23, 2018

4 checks passed

DCO All commits have a DCO sign-off from the author
Details
WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.