Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connCheckTimeout as flag #911

Merged
merged 1 commit into from
Jul 5, 2018
Merged

Conversation

henrod
Copy link
Contributor

@henrod henrod commented Jul 5, 2018

Which problem is this PR solving?

Adds a option to set connCheckTimeout. Now the value is hardcoded at 250ms.

Short description of the changes

Added a flag to accept a new timeout for connCheckTimeout (--discovery.conn-check-timeout) that receives a duration. Defaults to 250ms.

Signed-off-by: Henrique Rodrigues <henrique.93.rodrigues@gmail.com>
@codecov
Copy link

codecov bot commented Jul 5, 2018

Codecov Report

Merging #911 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #911   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         126    126           
  Lines        6072   6079    +7     
=====================================
+ Hits         6072   6079    +7
Impacted Files Coverage Δ
cmd/agent/app/builder.go 100% <ø> (ø) ⬆️
cmd/agent/app/reporter/tchannel/builder.go 100% <100%> (ø) ⬆️
cmd/agent/app/flags.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0b2331...90d8d70. Read the comment docs.

@black-adder black-adder merged commit 0c86682 into jaegertracing:master Jul 5, 2018
@black-adder
Copy link
Contributor

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants