Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move over internal ingester code to OSS #940

Merged
merged 2 commits into from
Jul 20, 2018
Merged

Move over internal ingester code to OSS #940

merged 2 commits into from
Jul 20, 2018

Conversation

vprithvi
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • This commit moves over code used internally at Uber to GitHub so that @davit-y may continue the work of adding initialization code.
  • The only changes done were moving import paths to GitHub, adding License headers and glide dependencies.

@codecov
Copy link

codecov bot commented Jul 19, 2018

Codecov Report

Merging #940 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #940    +/-   ##
======================================
  Coverage     100%   100%            
======================================
  Files         126    136    +10     
  Lines        6080   6322   +242     
======================================
+ Hits         6080   6322   +242
Impacted Files Coverage Δ
cmd/ingester/app/consumer/offset/manager.go 100% <100%> (ø)
...md/ingester/app/consumer/offset/concurrent_list.go 100% <100%> (ø)
cmd/ingester/app/processor/metrics_decorator.go 100% <100%> (ø)
cmd/ingester/app/consumer/consumer.go 100% <100%> (ø)
cmd/ingester/app/consumer/consumer_metrics.go 100% <100%> (ø)
cmd/ingester/app/processor/decorator/retry.go 100% <100%> (ø)
cmd/ingester/app/consumer/committing_processor.go 100% <100%> (ø)
cmd/ingester/app/processor/parallel_processor.go 100% <100%> (ø)
cmd/ingester/app/consumer/message.go 100% <100%> (ø)
cmd/ingester/app/consumer/processor_factory.go 100% <100%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 214c133...e504ca6. Read the comment docs.

@davit-y davit-y mentioned this pull request Jul 19, 2018
9 tasks
@yurishkuro
Copy link
Member

Rename mock_saramaConsumer.go to cmd/ingester/app/consumer/mock_saramaConsumer_test.go

What is this commit trying to achieve?

@vprithvi
Copy link
Contributor Author

What is this commit trying to achieve?

I wasn't able to find a easy way to exclude a single file from a package from coverage. Renaming with a _test works here because the mock is only used from tests.

The mock is not in a separate mocks package because the consumer interface it is mocking was declared private.

Signed-off-by: Prithvi Raj <p.r@uber.com>
@vprithvi
Copy link
Contributor Author

Build fails because of #945

@vprithvi vprithvi merged commit 933efb3 into master Jul 20, 2018
@ghost ghost removed the review label Jul 20, 2018
@vprithvi vprithvi deleted the add-ingester branch August 22, 2018 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants