Add producer folder to pkg/kafka/config #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davit-y
requested review from
black-adder,
jpkrohling,
pavolloffay,
vprithvi and
yurishkuro
as code owners
black-adder
approved these changes
Jul 25, 2018
plugin/storage/kafka/factory.go
Outdated
| } | ||
|
|
||
| // Initialize implements storage.Factory | ||
| func (f *Factory) Initialize(metricsFactory metrics.Factory, logger *zap.Logger) error { | ||
| f.metricsFactory, f.logger = metricsFactory, logger | ||
| logger.Info("Kafka storage configuration", | ||
| zap.Any("producer config", f.config), | ||
| logger.Info("Kafka producer builder", |
There was a problem hiding this comment.
s/Kafka producer builder/Kafka factory
Codecov Report
@@ Coverage Diff @@
## master #957 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 136 136
Lines 6322 6322
=====================================
Hits 6322 6322
Continue to review full report at Codecov.
|
black-adder
reviewed
Jul 25, 2018
plugin/storage/kafka/factory.go
Outdated
| logger.Info("Kafka producer builder", | ||
| zap.Any("producer builder", f.Builder), | ||
| logger.Info("Kafka factory", | ||
| zap.Any("producer factory", f.Builder), |
davit-y
force-pushed
the
split-kafka-config
branch
from
4f7729b
to
9575666
Compare
Merged
Signed-off-by: Davit Yeghshatyan <davo@uber.com>
davit-y
force-pushed
the
split-kafka-config
branch
from
9575666
to
956cc4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Davit Yeghshatyan davo@uber.com
Which problem is this PR solving?
Short description of the changes