Fix logging in the integration tests #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
requested review from
black-adder,
jpkrohling,
pavolloffay and
vprithvi
as code owners
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #986 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 139 139
Lines 6400 6400
=====================================
Hits 6400 6400Continue to review full report at Codecov.
|
yurishkuro
force-pushed
the
fix-test-logging
branch
from
dbbceb7
to
c1f3b4b
Compare
Signed-off-by: Yuri Shkuro <ys@uber.com>
yurishkuro
force-pushed
the
fix-test-logging
branch
from
c1f3b4b
to
fa812d9
Compare
black-adder
reviewed
Aug 14, 2018
| if err == nil && len(actual.Spans) == len(expected.Spans) { | ||
| break | ||
| if err != nil { | ||
| t.Log(err) |
There was a problem hiding this comment.
why does this test get special treatment? the other tests aren't logging the errors
There was a problem hiding this comment.
maybe they all should, but this is specifically the one that was sporadically failing yesterday for Kafka, so I want to get the logging into it for the future.
black-adder
approved these changes
Aug 14, 2018
isaachier
pushed a commit
to isaachier/jaeger
that referenced
this pull request
Sep 3, 2018
Signed-off-by: Yuri Shkuro <ys@uber.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling these changes out of #984.