f2fs:compress: fix a bug #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, there was a bug where user could see stale buffer cache (e.g, 512B) attached in the 4KB-sized pager cache, when the block size was changed from 512B to 4KB. That was fixed by: commit 5db470e ("loop: drop caches if offset or block_size are changed") But, there were some regression reports saying the fix returns EAGAIN easily. So, this patch removes previously added EAGAIN condition, nrpages != 0. Instead, it changes the flow like this: - sync_blockdev() - blk_mq_freeze_queue() : change the loop configuration - blk_mq_unfreeze_queue() - sync_blockdev() - invalidate_bdev() After invalidating the buffer cache, we must see the full valid 4KB page. Additional concern came from Bart in which we can lose some data when changing the lo_offset. In that case, this patch adds: - sync_blockdev() - blk_set_queue_dying - blk_mq_freeze_queue() : change the loop configuration - blk_mq_unfreeze_queue() - blk_queue_flag_clear(QUEUE_FLAG_DYING); - sync_blockdev() - invalidate_bdev() Report: https://bugs.chromium.org/p/chromium/issues/detail?id=938958#c38 Cc: <stable@vger.kernel.org> Cc: Jens Axboe <axboe@kernel.dk> Cc: linux-block@vger.kernel.org Cc: Bart Van Assche <bvanassche@acm.org> Fixes: 5db470e ("loop: drop caches if offset or block_size are changed") Reported-by: Gwendal Grignou <gwendal@chromium.org> Reported-by: grygorii tertychnyi <gtertych@cisco.com> Reviewed-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
…writing some files would fail when cluster.idx did not add
jaegeuk
force-pushed
the
g-dev-test
branch
7 times, most recently
from
af52b58
to
b657155
Compare
jaegeuk
force-pushed
the
g-dev-test
branch
13 times, most recently
from
db2167c
to
d0adea0
Compare
jaegeuk
force-pushed
the
g-dev-test
branch
5 times, most recently
from
32a5f29
to
f13578d
Compare
jaegeuk
force-pushed
the
g-dev-test
branch
2 times, most recently
from
460a9b8
to
c20a5c8
Compare
jaegeuk
force-pushed
the
g-dev-test
branch
16 times, most recently
from
607d493
to
477e5b3
Compare
jaegeuk
force-pushed
the
g-dev-test
branch
7 times, most recently
from
0f894ad
to
e22afea
Compare
jaegeuk
force-pushed
the
g-dev-test
branch
4 times, most recently
from
d74f720
to
ae015df
Compare
jaegeuk
force-pushed
the
g-dev-test
branch
2 times, most recently
from
96886cd
to
1314b19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f2fs:compress: Update isize after compress_write_end, otherwise apendwriting some files would fail when cluster.idx did not add