[api test] Got http-agent responding to post requests

lib/http-agent.js

@@ -113,8 +113,17 @@ httpAgent.HttpAgent.prototype = {
 
   _makeRequest: function (url) {
     var client = http.createClient(80, this.host);
-    var request = this._createRequest(client, url);
-
+
+    // Try to create the request or dispatch the error
+    try {
+      var request = this._createRequest(client, url);
+    }
+    catch (e) {
+      this.emit('next', e, self);
+      this.emit('stop', e, self);
+      return;
+    }
+
     var self = this;
     request.addListener('response', function (response) {
       response.setEncoding(self.encoding);
@@ -144,15 +153,36 @@ httpAgent.HttpAgent.prototype = {
   },
 
   _createComplexRequest: function (client, options) {
-    // TODO: Add post data to request, and other 
-    // options in the request options hash
-    return client.request(options.method, "/" + options.url, { "host": this.host });
+    // Check if we're doing a POST or a PUT and have data to send
+    var sendData = options.method.match(/^P/) && options.body && options.body.length > 0;
+
+    options.headers = options.header || {};
+    options.headers.Host = this.host;
+
+    if(sendData) {
+      options.headers['Content-Length'] = options.body.length;
+    }
+
+    var request = client.request(options.method, "/" + options.url, options.headers);
+    if(sendData) {
+      request.write(options.body, 'utf-8');
+    } 
+
+    return request;
   },
 
   _delegate: function (method, property) {
       var self = this;
       this[method] = function () {
           return self[property][method].apply(self[property], arguments);
       };
-  }
+  },
+
+  /*_extend: function (target, source) {
+    var prop;
+    Object.keys(source).forEach(function(prop) {
+      target[prop] = source[prop];
+    })
+    return target;
+  }*/
 };

test/complex-request-test.js

@@ -37,6 +37,16 @@ var complexUrls = [
 
 vows.describe('httpAgent').addBatch({
   "When using an httpAgent": {
+    "to browse an undefined url": {
+      topic: function () {
+        var agent = helpers.createAgent({ urls: [undefined] });
+        agent.addListener('next', this.callback);
+        agent.start();
+      },
+      "should throw an error": function (err, agent) {
+        assert.isNotNull(err);
+      }
+    },
     "to browse a path of complex urls": {
       "the next event": {
         topic: function () {
@@ -45,6 +55,7 @@ vows.describe('httpAgent').addBatch({
           agent.start();
         },
         "should be raised after start": function (e, agent) { 
+          eyes.inspect(e);
           assert.instanceOf(agent, httpAgent.HttpAgent);
           assert.isNotNull(agent.response);
         }

test/functional-request-test.js

@@ -0,0 +1,25 @@
+/*
+ * functional-request-test.js: Tests for functional requests (i.e. requests that generate 
+ *                             their own ClientRequest) using HttpAgent
+ *
+ * (C) 2010 Charlie Robbins
+ * MIT LICENSE
+ *
+ */
+
+var path = require('path'),
+    sys = require('sys'),
+    http = require('http'),
+    events = require('events'),
+    assert = require('assert'),
+    eyes = require('eyes'),
+		net = require('net'),
+    vows = require('vows');
+
+require.paths.unshift(path.join(__dirname, '..', 'lib'));
+
+var httpAgent = require('http-agent');
+
+vows.describe('httpAgent').addBatch({
+
+}).export(module);