Work around Content-type being empty in S3

jaens · Nov 6, 2021 · 16e14f7 · 16e14f7
1 parent 928bff6
commit 16e14f7
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/app/src/headers.js b/app/src/headers.js
@@ -14,7 +14,13 @@ const PDF_MIME_TYPES = new Set([
     "application/acrobat",
     "applications/vnd.pdf",
 ]);
-const BINARY_MIME_TYPES = new Set(["application/octet-stream", "application/force-download", "binary/octet-stream"]);
+const BINARY_MIME_TYPES = new Set([
+    "application/octet-stream",
+    "application/force-download",
+    "binary/octet-stream",
+    // S3 buckets might have files without Content-type set
+    "",
+]);
 const HEADER_CONTENT_DISPOSITION = "Content-Disposition";
 const HEADER_CONTENT_TYPE = "Content-Type";
 

diff --git a/test/test.js b/test/test.js
@@ -1,7 +1,7 @@
 "use strict";
 
-import * as headers from "../app/src/headers.js";
 import { deepStrictEqual } from "assert";
+import * as headers from "../app/src/headers.js";
 
 describe("Handle Headers", () => {
     testHandleHeaders("Empty", "", [], false);
@@ -161,6 +161,18 @@ describe("Handle Headers", () => {
             ["Content-Type", "application/pdf"],
         ]
     );
+    testHandleHeaders(
+        "Amazon S3 without content type with PDF file name(s)",
+        "http://some-bucket.s3.us-east-1.amazonaws.com/12345.pdf?response-content-disposition=attachment",
+        [
+            ["Content-Disposition", "attachment"],
+            ["Content-Type", ""],
+        ],
+        [
+            ["Content-Disposition", "inline"],
+            ["Content-Type", "application/pdf"],
+        ]
+    );
 });
 
 /* Helper Functions */