Skip to content

Commit

Permalink
handling date formating server side (which resolv issue with firefox …
Browse files Browse the repository at this point in the history
…mobile)

close #31
close #4
  • Loading branch information
jaesivsm committed Apr 17, 2016
1 parent b155968 commit 62b3c38
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 17 deletions.
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@
"object-assign": "^1.0.0",
"react": "^0.14.6",
"react-bootstrap": "^0.28.0",
"react-dom": "^0.14.6",
"react-intl": "^1.2.2"
"react-dom": "^0.14.6"
},
"devDependencies": {
"browserify": "^6.2.0",
Expand Down
8 changes: 3 additions & 5 deletions src/web/js/components/MiddlePanel.react.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ var TableLine = React.createClass({
feed_title: React.PropTypes.string.isRequired,
icon_url: React.PropTypes.string,
title: React.PropTypes.string.isRequired,
timestamp: React.PropTypes.number.isRequired,
rel_date: React.PropTypes.string.isRequired,
date: React.PropTypes.string.isRequired,
read: React.PropTypes.bool.isRequired,
selected: React.PropTypes.bool.isRequired,
Expand Down Expand Up @@ -48,12 +48,10 @@ var TableLine = React.createClass({
if(this.props.selected) {
clsses += " active";
}
// FIXME https://github.com/yahoo/react-intl/issues/189
// use FormattedRelative when fixed, will have to upgrade to ReactIntlv2
return (<div className={clsses} onClick={this.loadArticle} title={this.props.title}>
<h5><strong>{title}</strong></h5>
<JarrTime text={this.props.date}
stamp={this.props.timestamp} />
stamp={this.props.rel_date} />
<div>{read} {liked} {this.props.title}</div>
</div>
);
Expand Down Expand Up @@ -238,7 +236,7 @@ var MiddlePanel = React.createClass({
icon_url={article.icon_url}
read={article.read}
liked={article.liked}
timestamp={article.timestamp}
rel_date={article.rel_date}
date={article.date}
selected={article.selected}
article_id={article.article_id}
Expand Down
4 changes: 2 additions & 2 deletions src/web/js/components/RightPanel.react.js
Original file line number Diff line number Diff line change
Expand Up @@ -329,11 +329,11 @@ var Feed = React.createClass({
return (<div className="panel-body">
<dl className="dl-horizontal">
<dt>Created on</dt>
<dd><JarrTime stamp={this.props.obj.created_stamp}
<dd><JarrTime stamp={this.props.obj.created_rel}
text={this.props.obj.created_date} />
</dd>
<dt>Last fetched</dt>
<dd><JarrTime stamp={this.props.obj.last_stamp}
<dd><JarrTime stamp={this.props.obj.last_rel}
text={this.props.obj.last_retrieved} />
</dd>
</dl>
Expand Down
6 changes: 2 additions & 4 deletions src/web/js/components/time.react.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
var React = require('react');
var ReactIntl = require('react-intl');

var JarrTime = React.createClass({
mixins: [ReactIntl.IntlMixin],
propTypes: {stamp: React.PropTypes.number.isRequired,
propTypes: {stamp: React.PropTypes.string.isRequired,
text: React.PropTypes.string.isRequired},
render: function() {
return (<time dateTime={this.props.text} title={this.props.text}>
{this.formatRelative(this.props.stamp)}
{this.props.stamp}
</time>);
},
});
Expand Down
17 changes: 13 additions & 4 deletions src/web/views/home.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
import pytz
import logging
from calendar import timegm
from datetime import datetime

from flask import current_app, render_template, \
request, flash, url_for, redirect
from flask.ext.login import login_required, current_user
from flask.ext.babel import gettext
from babel.dates import format_datetime, format_timedelta

import conf
from web.lib.utils import redirect_url
Expand All @@ -17,6 +19,7 @@

from plugins import readability

localize = pytz.utc.localize
logger = logging.getLogger(__name__)


Expand All @@ -32,6 +35,7 @@ def home():
@etag_match
@jsonify
def get_menu():
now = datetime.utcnow()
categories_order = [0]
categories = {0: {'name': 'No category', 'id': 0}}
for cat in CategoryController(current_user.id).read().order_by('name'):
Expand All @@ -43,8 +47,10 @@ def get_menu():
categories[cat_id]['feeds'] = []
feeds = {feed.id: feed for feed in FeedController(current_user.id).read()}
for feed_id, feed in feeds.items():
feed['created_stamp'] = timegm(feed.created_date.timetuple()) * 1000
feed['last_stamp'] = timegm(feed.last_retrieved.timetuple()) * 1000
feed['created_rel'] = format_timedelta(now - feed.created_date)
feed['last_rel'] = format_timedelta(now - feed.last_retrieved)
feed['created_date'] = format_datetime(localize(feed.created_date))
feed['last_retrieved'] = format_datetime(localize(feed.last_retrieved))
feed['category_id'] = feed.category_id or 0
feed['unread'] = unread.get(feed.id, 0)
if not feed.filters:
Expand Down Expand Up @@ -92,6 +98,7 @@ def _get_filters(in_dict):

@jsonify
def _articles_to_json(articles):
now = datetime.utcnow()
fd_hash = {feed.id: {'title': feed.title,
'icon_url': url_for('icon.icon', url=feed.icon_url)
if feed.icon_url else None}
Expand All @@ -101,7 +108,8 @@ def _articles_to_json(articles):
'feed_id': art.feed_id, 'category_id': art.category_id or 0,
'feed_title': fd_hash[art.feed_id]['title'],
'icon_url': fd_hash[art.feed_id]['icon_url'],
'date': art.date, 'timestamp': timegm(art.date.timetuple()) * 1000}
'date': format_datetime(localize(art.date)),
'rel_date': format_timedelta(now - art.date)}
for art in articles.limit(1000)]}


Expand Down Expand Up @@ -131,6 +139,7 @@ def get_article(article_id, parse=False):
if feed.icon_url else None
readability_available = bool(current_user.readability_key
or conf.PLUGINS_READABILITY_KEY)
article['date'] = format_datetime(localize(article.date))
article['readability_available'] = readability_available
if parse or (not article.readability_parsed
and feed.readability_auto_parse and readability_available):
Expand Down

0 comments on commit 62b3c38

Please sign in to comment.