market orders aren't working

[tapesclub]

Hi, the example code to place a market order doesn't work—I'm not sure why, but it seems to be sending price information, which the api isn't expecting. Limit orders work fine.

Here's the error code I receive:

BUY(BNBBTC,1,0) { code: -1104,
msg: 'Not all sent parameters were not read; read '9' parameter(s) but was sent '10'.' }

[jaggedsoft]

Thank you for the report!
I created an update that fixes this issue. Please issue an npm update in your project directory.

I have verified it works with the following code:

const binance = require('node-binance-api');
binance.options({
  'APIKEY':'key',
  'APISECRET':'secret'
});
//Placing a MARKET order
var symbol = "BNBBTC", quantity = 1;
binance.buy(symbol, quantity, 0, {type:"MARKET"});

[tapesclub]

great thanks! nice work on all this btw. while i have your ear, could i make a feature request? (forgive me if this is implemented and I'm being an idiot, also possible.) i want to be able to trigger a second order after an order is completed, but as far as i can tell, i can't make use of the json response from binance on trade completion. basically i'd just like binance.buy/sell to return the callback like binance.cancel does, i think. thx again!

…

On Thu, Oct 19, 2017 at 10:35 PM, Jon Eyrick ***@***.***> wrote: Thank you for the report! I created an update that fixes this issue. Please issue an npm update in your project directory. I have verified it works with the following code: const binance = require('node-binance-api');binance.options({ 'APIKEY':'key', 'APISECRET':'secret' });//Placing a MARKET ordervar symbol = "BNBBTC", quantity = 1;binance.buy(symbol, quantity, 0, {type:"MARKET"}); — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AfaupLTcZZNq27E6meFQcMjVoBRmPiQWks5suDEzgaJpZM4P_-Mo> .

[jaggedsoft]

Thank you!
And great idea. I will work on this and keep you updated

[jaggedsoft]

Thank you for the suggestion!

I added callbacks to buy/sell functions and added a shortcut to make market orders easier. Now you can chain orders together.

var quantity = 1;
binance.marketBuy("BNBBTC", quantity, function(response) {
	console.log("Market Buy response", response);
	// Now you can limit sell with a stop loss, etc.
});

Any other features/bugs/suggestions let me know and I will be happy to help. If you open it as a new issue I will see it sooner. Thanks again!

[jaggedsoft]

Here are some new examples

Limit Buy

var quantity = 5, price = 0.00402030;
binance.buy("BNBETH", quantity, price, {}, function(response) {
	console.log("Limit Buy response", response);
	console.log("order id: " + response.orderId);
});

Limit Buy response { symbol: 'BNBETH',
  orderId: 4480717,
  clientOrderId: 'te38xGILZUXrPZHnTQPH6h',
  transactTime: 1509049732437,
  price: '0.00402030',
  origQty: '5.00000000',
  executedQty: '5.00000000',
  status: 'FILLED',
  timeInForce: 'GTC',
  type: 'LIMIT',
  side: 'BUY' }
//order id: 4480717

Market Buy

var quantity = 1;
binance.marketBuy("BNBBTC", quantity, function(response) {
	console.log("Market Buy response", response);
	console.log("order id: " + response.orderId)
	// Now you can limit sell with a stop loss, etc.
});

Market Buy response {
  symbol: 'BNBETH',
  orderId: 4480553,
  clientOrderId: 'rCGiCG08PGy7AwvbrG5d83',
  transactTime: 1509049376261,
  price: '0.00000000',
  origQty: '1.00000000',
  executedQty: '1.00000000',
  status: 'FILLED',
  timeInForce: 'GTC',
  type: 'MARKET',
  side: 'BUY' }
//order id: 4480553

Please navigate to your project directory and issue an npm update
Or run the command npm install node-binance-api --save