-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invite Deleter Ignores Redirecting Links #1
Comments
As cool of a feature it would be to follow redirects on all links,
I think a better solution to this problem is just to blacklist any redirect sites' urls once I add a blacklisting feature. |
What about only following known shortlinks, such as Google: https://developers.google.com/url-shortener/v1/getting_started#expand Only following these links shouldn't take up too many more resources or time. These websites may show a generic location to where it was from, but not your actual IP. To stop redirect loops, just set a limit. Here's some pseudocode to only follow Google and Bitly links:
This shouldn't loop too many times (maximum of A blacklist feature would make this easier, but it could delete links that are innocent. |
I don't like making a feature half-way, so while I appreciate the design, if I add a way to check links for redirects, it will check all links at a much larger depth. The exception to this might be things such as discord.me and other popular listing sites. |
Links such as
goo.gl
andbit.ly
links are ignored when checking for discord invite links.The only way I can think to fix this would be to send a GET request to every link sent and follow the redirects (unless there are too many redirects) to see if the final url matches your Regex found in src/vortex/AutoMod.java:57.
The text was updated successfully, but these errors were encountered: