Update to KSampler SDXL (Eff.) #134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the total number of steps when using the base model from steps to refine at step. There are two reasons I believe this is beneficial. 1) It allows EfficiencyNode users to duplicate exact image results they would get by using SDXL base and SDXL refiner separately using base comfyui. 2) It allows for iteration on an exact base image with a refiner rather than the base image changing when you increase the number of steps to add refiner steps on the end. @jags111 I couldn't find a working invite to a discord channel, but I'd be happy to join and discuss this change further with you.
|
will test this out and add same |
|
Sounds good. Let me know if there's anything I can do to help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the total number of steps when using the base model from steps to refine at step. There are two reasons I believe this is beneficial. 1) It allows EfficiencyNode users to duplicate exact image results they would get by using SDXL base and SDXL refiner separately using base comfyui. 2) It allows for iteration on an exact base image with a refiner rather than the base image changing when you increase the number of steps to add refiner steps on the end.
@jags111 I couldn't find a working invite to a discord channel, but I'd be happy to join and discuss this change further with you.