-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bandwidth limitation for clumsy #70
Conversation
prebuild binary: |
Excellent. |
Pls make a Clumsy 0.4 |
Sorry just saw this recently. I'll try test it a bit and make a newer release soon. |
Thanks @jagt, if you have a better implementation, feel free to close this PR. |
Thanks again! that would be awesome! I would like to see unlimited Latency no 3000ms cap, & maybe a new look in the GUI if possible? & add some new options, the bandwidth was a awesome feature! I'd like to see more features like that be added in the next release! #Clumsy 0.4 2021? (: |
When the actual bandwidth is close to the limited bandwidth, we should first queue packets to buffer and delay sending, rather than directly discard them. Algorithms such as Google Congestion Control using delay-based congestion controller will not work with this. WebRTC using this tool will cause the receiver's video to freeze periodically. |
@baiyufei , gcc also got a loss-based algorithm, when delay-based failed in prediction, loss-based algorithm will give a right answer. 这只是一个带宽限制模拟,无法保证 100% 还原真实世界的带宽限制问题,要还原需要做非常多的细节,像 QQ 电脑管家那种带宽现值法,据我观测和这个实现非常类似,也是只模拟丢包不模拟延迟,很多公司内部网络的限速网关,基本也是这样工作的。 |
Most routers have buffer. |
The bandwidth works perfectly in my opinion, I would just like too see more options be added as well, and maybe a new look to the program, so much potential in this old program. |
what bandwidth is used for? Didn't get it yet |
I'll merge this for now and try cut a new release soon. |
@skywind3000 I've uploaded a new release here: Since I'm not actively using clumsy can you help trying it out if you use it? Many thanks! Also I just noticed that your PR's user isn't linked with your github account, so it won't show in the repo contributors. If that matters to you you can submit the PR again with a linked account. I'll merge it so it would show up. |
I will test it out
…On Sun, May 9, 2021, 5:41 AM Chen Tao ***@***.***> wrote:
@skywind3000 <https://github.com/skywind3000> I've uploaded a new release
here:
https://github.com/jagt/clumsy/releases/tag/0.3rc3
Since I'm not actively using clumsy can you help trying it out if you use
it? Many thanks!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#70 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATA7MHAJ26KXNTSTDUJNB2TTMYHBBANCNFSM4MG7R4XQ>
.
|
I'd love to exercise this functionality. Any updates on how testing went and whether a new release might happen soon? |
@jagt @skywind3000 This functionality is amazing. This has been extremely useful for my purpose: I run some code in WSL1 and I need to benchmark it with different network settings, which include both latency and bandwith limitations. Clumsy is the only tool I found that made it work, for which I'm very thankful. I just want to ask, why measuring bandwith in Kilobit per second? More standard rates go in the order of Mbps no? Either way, I'm very thankful. |
Tried out 0.3rc3 and had it working without problems. |
the algorithm is from webrtc:
https://github.com/JumpingYang001/webrtc/blob/6f80f098ec957b1a8f816cbf4a8e1d32a37b1685/rtc_base/rate_statistics.h#L20
and:
https://github.com/JumpingYang001/webrtc/blob/6f80f098ec957b1a8f816cbf4a8e1d32a37b1685/rtc_base/rate_limiter.h#L27