New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes #1
Open
palfrey
wants to merge
5
commits into
jah-photoshop:master
Choose a base branch
from
palfrey:various-fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi mate,
Sorry don't check this account much! Hadn't realised anyone was looking at
it but thanks for doing so!
The problem is they changed the way MSOA data is published - and long story
short I hadn't updated the code. Used to be a wide spreadsheet each week
represented as a column, but now it's unstacked.
I'm not so interested in plotting at MSOA level anymore - so a lot of the
code is unneeded (a lot of the work is in cross-referencing LTLAs to MSOAs)
- the LTLA shape file could be used instead. I used a dummy updated
old-style MSOA file as a workaround (attached)
…On Sat, 31 Oct 2020 at 22:42, Tom Parker-Shemilt ***@***.***> wrote:
I was trying to get this running locally, and fixed a few things
- Corrected the data download scripts hosts
- Added a script to download the shape files
- Listed out the Python requirements
I'm still getting an error when trying to run map_plot, but these bits at
least got me part of the way in.
Traceback (most recent call last):
File "map_plot.py", line 257, in <module>
if(day % 7 == day_offsets[count][week]): day_rate += ( 0 if int(msoa_data[count][week+8]) < 0 else int(msoa_data[count][week + 8]) )
IndexError: list index out of range
Any thoughts on that one?
------------------------------
You can view, comment on, or merge this pull request online at:
#1
Commit Summary
- Replace uses of c19downloads to working site
- Remove lockfile
- Add helper script for downloading shape files
- Add list of Python requirements
- Update README with fixes and new items
File Changes
- *M* .gitignore
<https://github.com/jah-photoshop/autocovid/pull/1/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947>
(3)
- *M* README.md
<https://github.com/jah-photoshop/autocovid/pull/1/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5>
(9)
- *D* ages/.~lock.age_risk_index.csv#
<https://github.com/jah-photoshop/autocovid/pull/1/files#diff-d97e0bb019693e2a59cf40c6a8ede85d6bde771ba60fa966a53a6fcff89c293d>
(1)
- *M* download_data.sh
<https://github.com/jah-photoshop/autocovid/pull/1/files#diff-0707b1b55bd35e7c45872701c6dd61aa00327fcb221e672f2a9fa1804a3724da>
(8)
- *M* download_data_backup.sh
<https://github.com/jah-photoshop/autocovid/pull/1/files#diff-b4cabdafc460c531e8edc87ec4ed274d54d86b2ea583794115f1673e009eefe0>
(10)
- *A* download_shape_files.sh
<https://github.com/jah-photoshop/autocovid/pull/1/files#diff-ecc6dd5c68e4adebdcd5bfae2d6d82b98f7821a29ceb61946d097c63baad0a1d>
(19)
- *A* requirements.txt
<https://github.com/jah-photoshop/autocovid/pull/1/files#diff-4d7c51b1efe9043e44439a949dfd92e5827321b34082903477fd04876edb7552>
(6)
Patch Links:
- https://github.com/jah-photoshop/autocovid/pull/1.patch
- https://github.com/jah-photoshop/autocovid/pull/1.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARFDMII4L4TU65WYVKTNVQ3SNSHENANCNFSM4TGEQNXA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to get this running locally, and fixed a few things
I'm still getting an error when trying to run map_plot, but these bits at least got me part of the way in.
Any thoughts on that one?