Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to TypeScript #10

Closed
jahed opened this issue Aug 21, 2020 · 1 comment · Fixed by #12
Closed

Migrate to TypeScript #10

jahed opened this issue Aug 21, 2020 · 1 comment · Fixed by #12
Labels

Comments

@jahed
Copy link
Owner

jahed commented Aug 21, 2020

To avoid using unsupported Node APIs and dealing with version compatibility, migrate to TypeScript and add a build step.

It might be convenient at this point to switch to async/await and drop @jahed/promises for better readability.

@jahed jahed added the chore label Aug 21, 2020
@jahed
Copy link
Owner Author

jahed commented May 11, 2021

Tried migrating:

5a5a7ca

Because the package relies on an install hook which points to a lib file, it's a sort of a chicken and egg problem. I need to install deps to build, but the install step involves running a built file.

I could use --ignore-scripts for CI installs but that will ignore all scripts, including dev dependencies which may need them. I tried the various hook but NPM/Yarn lifecycle hooks are inconsistent across versions and it's a minefield knowing what executes only locally and in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant