Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

labelVisibilityMode Does not Work #264

Closed
1 task done
KoleHoenicke opened this issue Aug 13, 2023 · 4 comments
Closed
1 task done

labelVisibilityMode Does not Work #264

KoleHoenicke opened this issue Aug 13, 2023 · 4 comments

Comments

@KoleHoenicke
Copy link

KoleHoenicke commented Aug 13, 2023

Requirements

  • I have verified there are no duplicate active or recent bugs, questions, or requests

Frames Version

3.5.7

Android Version

14

Device Manufacturer

Google

Device Name

Pixel 7 Pro

What happened?

Having labelVisibilityMode as anything other than auto doesn't work.

Reproduction Steps

In styles.xml, change auto to either labeled, unlabeled, or selected and it won't make any difference in the app.

Expected behavior

Changing the mode should affect what you see in the app, but it does not.

Screenshots or videos

https://imgur.com/a/wfmFHp7

Code and/or Logs

?xml version="1.0" encoding="utf-8"?>


<style name="MyApp" />

<!--
    Splash screen theme follow device's theme
    You can change the parent to any of these:
    - Frames.SplashScreen
    - Frames.SplashScreen.Amoled
    - Frames.SplashScreen.MaterialYou
    - Frames.SplashScreen.Amoled.MaterialYou
-->
<style name="MyApp.SplashScreen" parent="Frames.SplashScreen">
    <item name="customFontBold">@font/manrope_bold_fam</item>
    <item name="customFontNormal">@font/manrope_normal_fam</item>
</style>

<!-- Don't change the parent style -->
<style name="MyApp.Default" parent="Frames.Default">
    <item name="bottomNavigationStyle">@style/MyApp.BottomNavigationView</item>
    <item name="customFontBold">@font/manrope_bold_fam</item>
    <item name="customFontNormal">@font/manrope_normal_fam</item>
</style>

<!-- Don't change the parent style -->
<style name="MyApp.Default.Amoled" parent="Frames.Default.Amoled">
    <item name="bottomNavigationStyle">@style/MyApp.BottomNavigationView</item>
    <item name="customFontBold">@font/manrope_bold_fam</item>
    <item name="customFontNormal">@font/manrope_normal_fam</item>
</style>

<!-- Don't change the parent style -->
<style name="MyApp.BottomNavigationView" parent="Widget.Frames.BottomNavigationView">
    <!--
        Switch bottom navigation labels visibility style
        You can use any of there:
        - auto
        - labeled
        - unlabeled
        - selected

        Learn more: https://developer.android.com/reference/com/google/android/material/bottomnavigation/LabelVisibilityMode
    -->
    <item name="labelVisibilityMode">selected</item>
</style>

Additional context or info

No response

Copy link
Owner

You can pledge behind and help support this effort using Polar.sh

Fund with Polar

@jahirfiquitiva
Copy link
Owner

@kolepsd would you mind adding the code for your modified styles.xml

@KoleHoenicke
Copy link
Author

Added.

@jahirfiquitiva
Copy link
Owner

@kolepsd have you tried updating the styles in the m3_styles.xml file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants