Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom Sheet doesn't draw behind on-screen navbar (on devices with on-screen navbar) #63

Closed
2 tasks done
SanchithHegde opened this issue May 8, 2018 · 8 comments
Closed
2 tasks done

Comments

@SanchithHegde
Copy link

  • I have verified there are no duplicate active or recent bugs, questions, or requests
  • I have verified that I am using the latest version of Frames.

Device/dashboard info:

  • Frames version: 2.3.5
  • Android version: 8.1
  • Device Manufacturer: Motorola
  • Device Name: Moto G3 (2015)

Reproduction Steps

This is noticed on devices with on-screen navbar only and when bottom sheet is enabled for displaying wallpaper info.

  1. Go to wallpaper preview screen.
  2. Tap on wallpaper info icon (i enclosed in a circle).
  3. The bottom sheet displaying wallpaper info is shown.

Expected Result

The bottom sheet draws up behind the navbar too, maintaining uniformity.

Actual Result

The bottom sheet doesn't draw behind the navbar, but draws up from the region above it.

Screenshot

Sscreenshot
Screenshot of a wallpaper from Blueprint sample app.
@welcome
Copy link

welcome bot commented May 8, 2018

Thanks for opening your first issue here 😃! Please be sure to follow the issue template and check the contribution guidelines 😉 (otherwise the issue will be ignored 😕).

@jahirfiquitiva
Copy link
Owner

This is android default behavior. The bottom sheet always appear above the navigation bar. Nothing I can do.

@SanchithHegde
Copy link
Author

Ahh okay.

@jahirfiquitiva
Copy link
Owner

@SanchithHegde I'll reopen this. I think is possible. Anyways, it would require a huge overwrite of the current implementation.

@jahirfiquitiva jahirfiquitiva reopened this May 8, 2018
@SanchithHegde
Copy link
Author

Thank You!

@jahirfiquitiva jahirfiquitiva added this to the 3.0.0 milestone May 14, 2018
@stale
Copy link

stale bot commented Jun 1, 2018

This issue has been automatically marked as stale because it has not had activity in the last three (3) days. It will be closed if no further activity occurs within the next four (4) days. Thank you for your contributions.

@stale stale bot added the stale label Jun 1, 2018
@jahirfiquitiva
Copy link
Owner

Looking good enough on Frames 2.5.3 ... Will keep it like that 😅🤷🏻‍♂️

@lock
Copy link

lock bot commented Oct 10, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants