Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Useless condition #4

Closed
KittyGiraudel opened this issue Jan 27, 2015 · 1 comment
Closed

Useless condition #4

KittyGiraudel opened this issue Jan 27, 2015 · 1 comment

Comments

@KittyGiraudel
Copy link
Contributor

@if variable-exists('ext-options') {
  $ext-opt: map-merge($ext-opt, $ext-options) !global;
}

Since you define $ext-options on top of the file and there is no way in Sass to unset a variable, this condition will always be met.

A more appropriate check would be:

@if type-of($ext-options) == 'map' {
  $ext-opt: map-merge($ext-opt, $ext-options) !global;
}

If you agree, I can submit a PR.

@jaicab
Copy link
Owner

jaicab commented Jan 27, 2015

This if statement was inherited from an older version of the plugin which didn't have any defaults. All very true, fixed on #8.

@jaicab jaicab closed this as completed Jan 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants