-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed Version 4.0.0 #51
Conversation
https://github.com/github/gitignore/blob/main/VisualStudio.gitignore - Update test to supported .net6 - Update nugets
- The lowest framework supported is 4.6.2 - Add CodePages to netstandard project to support net6 - net6 tests prove that this closes jaime-olivares#43
- One class per file - Make public fields properties - Do not use Microsoft namespaces! - C# naming conventions - Implement async - Add ExtractToFolder - Always put Dispose in Finally or using - Refactor and cleanup
- Closes jaime-olivares#39 - Closes jaime-olivares#22 - Closes jaime-olivares#37
- Extract to directory will overwrite
- Closes jaime-olivares#48 - Make sync and async behavior the same
Now closes #48 |
Thanks @A9G-Data-Droid, |
Any update on this? |
It might be easier to review and merge #50 first, as this one is building upon that same branch. |
Any updates? |
Have you tested my branch? You can review the code yourself and use my version until this is accepted. |
I am sorry. I cannot accept this PR, for the following reasons:
|
This goes much farther than my first PR, into the realm of breaking changes.