Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed Version 4.0.0 #51

Closed
wants to merge 6 commits into from

Conversation

A9G-Data-Droid
Copy link

@A9G-Data-Droid A9G-Data-Droid commented Oct 27, 2023

This goes much farther than my first PR, into the realm of breaking changes.

 - The lowest framework supported is 4.6.2
 - Add CodePages to netstandard project to support net6
 - net6 tests prove that this closes jaime-olivares#43
 - One class per file
 - Make public fields properties
 - Do not use Microsoft namespaces!
 - C# naming conventions
 - Implement async
 - Add ExtractToFolder
 - Always put Dispose in Finally or using
 - Refactor and cleanup
 - Extract to directory will overwrite
 - Closes jaime-olivares#48
 - Make sync and async behavior the same
@A9G-Data-Droid
Copy link
Author

Now closes #48

@jaime-olivares
Copy link
Owner

Thanks @A9G-Data-Droid,
Those are indeed a lot of changes in a single PR, not possible to select individual ones.
I will review asap.
--Jaime.

@andreoromera
Copy link

Any update on this?

@A9G-Data-Droid
Copy link
Author

A9G-Data-Droid commented Jun 3, 2024

It might be easier to review and merge #50 first, as this one is building upon that same branch.

@andreoromera
Copy link

Any updates?
Client is constantly complaining about this.
They need to upload files bigger than 4gb.
Any help would be truly appreciated!

@A9G-Data-Droid
Copy link
Author

Have you tested my branch? You can review the code yourself and use my version until this is accepted.

@jaime-olivares
Copy link
Owner

I am sorry. I cannot accept this PR, for the following reasons:

  • It covers too many aspects at a time.
  • It changes the structure of the source code files (it was a one-filer)
  • It changes the namespace, breaking all code from existing users
  • It removes the build of other platforms than .net standard 2.0, that many users may be using
  • Hard to track changes as too many files are renamed/relocated

@jaime-olivares jaime-olivares mentioned this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment