i need a way to know the status of the scrape, and if it failed, why. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Might be better just to raise, not sure, feel free to refactor :)
|
i can add some tests this week |
|
@rromanchuk this would be great. I just released 1.9.1 and it includes the ability to set a timeout, so the scraping doesn't wait forever. In your specs, if you want to simulate a TimeoutException, just set a very low timeout, like: |
|
@rromanchuk I've released metainspector 1.9.3, which merges your additions. I've fixed what was broken. Tell me if this works for you, and if it doesn't, just send me a pull request, you know :) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might be better just to raise, not sure, feel free to refactor :)