New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for setting headers #63
Conversation
Thank you @ainformatico -- I like the idea, but this needs specs for the new feature. I can merge this as soon as the specs are added and the broken specs are fixed. |
sorry, I forgot the tests. I just patched what I needed. |
Ensure we have an object and not nil
I hope is enough. |
Looks good, thanks! Let me review this tomorrow before I merge it. |
Is it already possible to pass user agent? |
No, this hasn't been merged yet, we're waiting for the specs. I can deal with them on the following days if there's no further activity. |
Sorry, for some reason Github stopped sending me notifications emails until now. I would recommend to set the default user agent to be like:
|
@ainformatico I've merged your commits and added specs here a72aad4 I've released it as 2.2.0, can you try it to see if it works as expected? Thanks! |
works like a charm! Thanks. |
Usefull for example when setting the
User-Agent
.