Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting headers #63

Merged
merged 4 commits into from Apr 30, 2014

Conversation

ainformatico
Copy link
Contributor

Usefull for example when setting the User-Agent.

@jaimeiniesta
Copy link
Owner

Thank you @ainformatico -- I like the idea, but this needs specs for the new feature. I can merge this as soon as the specs are added and the broken specs are fixed.

@ainformatico
Copy link
Contributor Author

sorry, I forgot the tests. I just patched what I needed.
I'll do it.

Alejandro Espinoza added 2 commits April 22, 2014 21:43
Ensure we have an object and not nil
@ainformatico
Copy link
Contributor Author

I hope is enough.

@jaimeiniesta
Copy link
Owner

Looks good, thanks!

Let me review this tomorrow before I merge it.

@ugran
Copy link

ugran commented Apr 29, 2014

Is it already possible to pass user agent?

@jaimeiniesta
Copy link
Owner

No, this hasn't been merged yet, we're waiting for the specs. I can deal with them on the following days if there's no further activity.

@ainformatico
Copy link
Contributor Author

Sorry, for some reason Github stopped sending me notifications emails until now.
I won't have time this week to work on this, if you can do it please go ahead.

I would recommend to set the default user agent to be like:

"MetaInspector/#{MetaInspector::VERSION} (+https://github.com/jaimeiniesta/metainspector)"

@jaimeiniesta jaimeiniesta merged commit 7fe3e36 into jaimeiniesta:master Apr 30, 2014
@jaimeiniesta
Copy link
Owner

@ainformatico I've merged your commits and added specs here a72aad4

I've released it as 2.2.0, can you try it to see if it works as expected?

Thanks!

@ainformatico
Copy link
Contributor Author

works like a charm!

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants