Aho corasick #1395
Merged
Aho corasick #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into Aho-Corasick
manbirmarwah
previously requested changes
May 26, 2019
Aho-Corasick/Aho-Corasick.cpp
Outdated
| of a finite set of strings (the "dictionary") within an input text. | ||
| It matches all strings simultaneously.*/ | ||
|
|
||
| const int MAXSTATETATE = 6 * 50 + 10; |
There was a problem hiding this comment.
MAXSTATETATE sounds confusing/misspelled. Can you use something else in this place?
Aho-Corasick/Aho-Corasick.cpp
Outdated
| memset(out, 0, sizeof out); //intializing out with 0s | ||
| memset(fail, -1, sizeof fail); //intializing fail with -1s | ||
| memset(g, -1, sizeof g); //intializing g with -1s | ||
| int states = 1; // Initially, we just have the 0 state |
There was a problem hiding this comment.
Please use unified indentation for comments throughout the code.
Aho-Corasick/Aho-Corasick.cpp
Outdated
| int currentState = 0; | ||
| for (int j = 0; j < keyword.size(); j++) | ||
| { | ||
| int c = keyword[j] - lowestChar; |
Aho-Corasick/Aho-Corasick.cpp
Outdated
| { | ||
| int c = keyword[j] - lowestChar; | ||
| if (g[currentState][c] == -1) | ||
| { // Allocate a new node |
There was a problem hiding this comment.
Put comment in newline.
Aho-Corasick/Aho-Corasick.cpp
Outdated
| vector<string> keywords; | ||
| cout<<"Enter the number of keywords you want to enter"; | ||
| int n; | ||
| for(int i = 0; i < n; i++) |
Aho-Corasick/Aho-Corasick.cpp
Outdated
| { | ||
| string temp; | ||
| cin >> temp; | ||
| keywords.push_back(temp); |
There was a problem hiding this comment.
Fix indentation in above 3 lines.
Aho-Corasick/Aho-Corasick.cpp
Outdated
| } | ||
| cout << "Enter text"; | ||
| string text; | ||
| cin >> text; |
There was a problem hiding this comment.
No need to add space input (>>) and output (<<) operators in cin and cout statements.
Aho-Corasick/Aho-Corasick.cpp
Outdated
| if (out[currentState] == 0) | ||
| { | ||
| continue; // Nothing new, moving on to the next character. | ||
| } |
There was a problem hiding this comment.
Fix indentation in above 3 lines.
Aho-Corasick/Aho-Corasick.cpp
Outdated
| for (int j = 0; j < keywords.size(); j++) | ||
| { | ||
| if (out[currentState] & (1 << j)) | ||
| { // Matched keywords[j] |
There was a problem hiding this comment.
Put comment in newline.
|
@marwahmanbir made the changes. |
jainaman224
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #624
Checklist:
Changes proposed in this pull request:
Languages Used:
Files Added: