Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Minimum Cost Path #1423

Merged
merged 1 commit into from May 28, 2019
Merged

Added Minimum Cost Path #1423

merged 1 commit into from May 28, 2019

Conversation

somya-kapoor
Copy link
Collaborator

Fixes #1396

Checklist:

  • 4 space indentation.
  • Coding conventions are followed.
  • Input is taken dynamically.
  • Sample Input / Output is added at the end of file.
  • Logic Documentation (Comments).
  • File names are correct.

Changes proposed in this pull request:

  • added Min Cost Path in 2d-Array

Languages Used:

  • C
  • C++
  • java
  • python

Files Added:

  • Minimum_Cost_Path.c
  • Minimum_Cost_Path.cpp
  • Minimum_Cost_Path.java
  • Minimum_Cost_Path.py

manbirmarwah
manbirmarwah previously approved these changes May 28, 2019
View reviewed changes
Copy link
Contributor

@manbirmarwah manbirmarwah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ✨

MastersAbh
MastersAbh requested changes May 28, 2019
View reviewed changes
Copy link
Collaborator

@MastersAbh MastersAbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the following changes

Minimum_Cost_Path/Minimum_Cost_Path.c Outdated
return array[left][right];
else
{
// Finging path with minimum cost i.e. which way to move down, right and diagonally lower cells
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in finding

Minimum_Cost_Path/Minimum_Cost_Path.c Outdated Show resolved Hide resolved
Minimum_Cost_Path/Minimum_Cost_Path.c Outdated Show resolved Hide resolved
Minimum_Cost_Path/Minimum_Cost_Path.c Outdated Show resolved Hide resolved
Minimum_Cost_Path/Minimum_Cost_Path.cpp Outdated Show resolved Hide resolved
Minimum_Cost_Path/Minimum_Cost_Path.cpp Outdated Show resolved Hide resolved
Minimum_Cost_Path/Minimum_Cost_Path.cpp Outdated Show resolved Hide resolved
Minimum_Cost_Path/Minimum_Cost_Path.java Outdated Show resolved Hide resolved
@somya-kapoor
Copy link
Collaborator Author

@MastersAbh Done please review

@somya-kapoor
Copy link
Collaborator Author

@marwahmanbir Please review.

@jainaman224 jainaman224 merged commit 516d2c0 into jainaman224:master May 28, 2019
@somya-kapoor somya-kapoor deleted the patch-4 branch May 29, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MastersAbh MastersAbh MastersAbh requested changes

@jainaman224 jainaman224 jainaman224 approved these changes

@manbirmarwah manbirmarwah manbirmarwah left review comments

Assignees
No one assigned
Labels
gssoc19
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Min Cost Path in 2d-Array
4 participants
@somya-kapoor @jainaman224 @manbirmarwah @MastersAbh