Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Mix of flat and 3-dimensional elements #48

Open
kfischer opened this issue Sep 19, 2022 · 5 comments
Open

Mix of flat and 3-dimensional elements #48

kfischer opened this issue Sep 19, 2022 · 5 comments

Comments

@kfischer
Copy link
Contributor

This is something a coworker of mine noticed: We are mixing 2 different styles on the different elements.

Two examples:

Example 1: Everything is flat, but the background 'tiles' of the different patron information sections:
grafik

Example 2: Everything is flat, but for the news entries. I feel like this makes them stand out more.

grafik

Not sure if this was discussed before maybe.

@jajm
Copy link
Owner

jajm commented Sep 26, 2022

It was already like that in the design documents, for instance:
image
image

Side menus are flat/grey and the rest is inside white "cards" with shadow

What should we do about it ?

About the news specifically, we can make it stick to the left border of the screen to be more consistent, but that's another issue

@kfischer
Copy link
Contributor Author

I think moving to the left might be more consistent - good point, small issue tho.

Are the settings the same on news and the other cards? The shadow appears much more prominent there.

@jajm
Copy link
Owner

jajm commented Sep 28, 2022

I'm tempted to close this issue, or to modify it to make it about the news block only. Do you agree @kfischer ?

@mrenvoize
Copy link
Contributor

This has sort of moved to Bug 31747 - Round corners in boxes.

I've adapted Lucas's submission there to try and make 'News', 'Userblock' and 'Quote' sections all use the 'page-section' card type styling.. at least that improves our consistency... though I still feel perhaps news and quotes may not really fit that scheme as jajm highlights above.. they feel weird as 'sections'/'cards' on the left when everywhere else we try to keep the left side as a 'navbar' type section.

We probably still need to have the broader discussion around flat vs 3d though.. I'll open another bug for that.

@mrenvoize
Copy link
Contributor

I've added Bug 31762 - Flat vs 3D or Mixed where I remove the box-shadow.. I think it looks nice.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants