"Card" inconsistency in biblio display

[mrenvoize]

With the addition of a card layout to the Patron module pages, I think for consistency it would be nice to add such cards to Biblio details pages too..

vs

[mrenvoize]

This is perhaps another one out of scope of the initial styling work.. however I thought it worth mentioning as it may be the right time to consider it.. right now it appears we're using a 'patroninfo-section' class for styling this on the patron pages.. maybe a more generic 'info-section' or something class would be beneficial to use more globally?

Happy to open this as a distinct bug to track the markup change it may require as a separate piece of work though.. let me know if you think that's more appropriate.

[kfischer]

Not sure what is meant by adding the 'cards' on the detail page and what this would look like. What do you think about #48?

[mrenvoize]

By 'Card' I mean 'box' around each content area on the page with a white background... so in the above images the 'Contact information' stuff is all in a 'Card'.. I could envisage the biblio details stuff all being in their own 'Card' too for consistency.

[kfischer]

So should the main content always appear in a card?

[mrenvoize]

So should the main content always appear in a card?

Card or Cards in my opinion.. it gives a nice clear distinction for 'sections' of the page.

[kfischer]

I am not sure really how well that would work really, where is lots more page where this might play a role then.

[jajm]

I added a CSS class page-section that can be reused everywhere it's needed. I didn't use the word 'card' because it would conflict with Bootstrap 4 cards (in case of upgrade)

[mrenvoize]

Thanks @jajm, I think this brings us a step closer... I think I'd keep the overall page heading outside of the page-section div for consistency.. but that's an easy follow-up I'd be happy to submit later.

[jajm]

Thanks @jajm, I think this brings us a step closer... I think I'd keep the overall page heading outside of the page-section div for consistency.. but that's an easy follow-up I'd be happy to submit later.

I'm not sure if it can be done, as the title is part of the result of XSLT processing.

[mrenvoize]

Thanks @jajm, I think this brings us a step closer... I think I'd keep the overall page heading outside of the page-section div for consistency.. but that's an easy follow-up I'd be happy to submit later.

I'm not sure if it can be done, as the title is part of the result of XSLT processing.

Good point.. I hadn't realized that.. Certainly not one to try to do as part of this bug.

[mrenvoize]

Closing